Volume destroy data race - #933
Merged
nnastonen merged 1 commit intoOct 2, 2026
Merged
Conversation
nnastonen
force-pushed
the
SDSTOR-25815_volume_dstroy_data_race_bug
branch
from
October 1, 2026 08:45
55cae52 to
8a7d977
Compare
nnastonen
changed the title
Contributor
|
Good catch! Approve. The race fix is correct and the mutex fence is sound. After destroy() freed m_rd_sb, a concurrent CP could still call cp_flush on the device (still visible in m_rd_map), hitting a null dereference. The fix erases from the map before destroy(). After the erase no future iterate_repl_devs() can find this device. |
shosseinimotlagh
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After volume destroy, the device is still in m_rd_map. A CP that fires in that window calls cp_flush on a device whose superblock is gone, and that null dereference causes the crash.
https://jirap.corp.ebay.com/browse/SDSTOR-25815