Conversation
nnastonen
force-pushed
the
SDSTOR-25815_volume_dstroy_data_race_bug_v7
branch
from
October 1, 2026 09:00
b4f459d to
cfa332d
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The concurrency fix lacks a deterministic regression test for checkpoint and device-removal overlap.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Prevents checkpoint callbacks from accessing a destroyed solo replication device.
Changes:
- Removes devices from the replication map before resource destruction.
- Waits for active device iterations to finish.
- Bumps the package version and applies formatting updates.
| File | Description |
|---|---|
generic_repl_svc.cpp |
Reorders device removal and destruction. |
raft_repl_service.h |
Formatting only. |
test_raft_repl_dev.cpp |
Formatting only. |
conanfile.py |
Bumps version to 7.6.2. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
shosseinimotlagh
approved these changes
Oct 5, 2026
shosseinimotlagh
left a comment
shosseinimotlagh
left a comment
Contributor
There was a problem hiding this comment.
LG. @nnastonen please wait for @JacksonYao287 approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After volume destroy, the device is still in m_rd_map. A CP that fires in that window calls cp_flush on a device whose superblock is gone, and that null dereference causes the crash.
https://jirap.corp.ebay.com/browse/SDSTOR-25815