Clear error for invalid joint-fit weights#205
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #205 +/- ##
========================================
Coverage 90.29% 90.30%
========================================
Files 283 283
Lines 24152 24175 +23
Branches 2828 2834 +6
========================================
+ Hits 21809 21832 +23
Misses 1747 1747
Partials 596 596
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fitting several experiments together, each experiment is given a weight that controls how strongly it influences the result. Previously, entering an invalid set of weights — a negative value, weights that are not valid numbers, or all weights set to zero — could silently spoil the fit and return meaningless results, with no indication that anything was wrong.
EasyDiffraction now checks the joint-fit weights before fitting begins and stops with a clear, explanatory message when they are negative, not-a-number, or all zero (and when the number of weights does not match the number of experiments). You get an immediate, understandable error and can fix the weights straight away, instead of chasing a confusing failed refinement.