Skip to content

CI: Schema files are written to a path the tests don't read, so the schema tests always skip #637

Closed

Description

@leogrox

pr.yml downloads the schema files into ./test/adapter/schema:

https://github.com/eclipse-basyx/basyx-python-sdk/blob/develop/.github/workflows/pr.yml#L104-L106

The tests read them from ../schemas/, that is test/adapter/schemas, which is also the path .gitignore covers (L27). The files never reach the tests, so JsonSerializationSchemaTest and XMLSerializationSchemaTest skip their entire class on every run. That is the skipped=2 in a green run, e.g. run 35359692685 on develop:

Ran 267 tests in 1.599s
OK (skipped=2)

So no serialization has been validated against the official AAS schema in CI. Issue #636 is what that hid: the JSON serializer emits an array the schema rejects, and both schema tests catch it the moment the files land in the right directory.

Renaming the directory in the workflow is enough to make them run. Two things worth deciding beyond that:

  • The skip is silent. setUpClass skipping when the file is missing is right for a local run, but in CI it turns a missing schema into a green build. An env var that makes the absence fatal there would keep both.
  • test/adapter/schema vs schemas reads like a typo anyone can repeat. Pointing both the workflow and the tests at one constant, or having the test download the file itself, removes the coupling.

Happy to send the rename, and either of the other two if you want them.

Activity

  1. added a commit that references this issue on Oct 6, 2026
    c3b28b1
  2. zrgt commented on Oct 6, 2026

    @zrgt
    Contributor

    Fixed in #639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions