Repository navigation
[GTK4] Draw plain Composite backgrounds as color nodes - #3693
Merged
akurtakov merged 1 commit intoOct 7, 2026
Merged
Conversation
Redrawing a control runs the snapshot of all its ancestors again, and Composite.snapshotBackground() appended a new Cairo node of its full size for each of them, the Shell included. Cairo nodes are not diffed, so every redraw damaged the whole window, and the renderer rasterized and uploaded all of it again. This made scrolling in StyledText slow. Append a color node for a background color, which is diffed by value. Background images still use Cairo. See eclipse-platform#3583 Assisted-by: Anthropic Claude Code (claude-opus-5-5)
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused optimization preserves existing rendering semantics and manages native resources correctly.
Review effort: Balanced
Findings: None
What changed in this PR
Optimizes GTK4 Composite background rendering to prevent full-window redraw damage during scrolling.
Changes:
- Uses diffable GTK color nodes for solid backgrounds.
- Retains Cairo rendering for background images.
- Preserves transparent-region behavior.
| File | Description |
|---|---|
Composite.java |
Selects optimized GTK4 snapshot rendering based on background type. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redrawing a control runs the snapshot of all its ancestors again, and Composite.snapshotBackground() appended a new Cairo node of its full size for each of them, the Shell included. Cairo nodes are not diffed, so every redraw damaged the whole window, and the renderer rasterized and uploaded all of it again. This made scrolling in StyledText slow.
Append a color node for a background color, which is diffed by value. Background images still use Cairo.
See #3583
Assisted-by: Anthropic Claude Code (claude-opus-5-5)