Repository navigation
[GTK4] Expand and collapse Tree rows with Left and Right - #3694
Merged
akurtakov merged 1 commit intoOct 7, 2026
Merged
Conversation
The Left and Right bindings added to the GtkTreeView class came after GtkTreeView's own move-cursor bindings, which handle the keys first, so they never ran. Handle the keys in the key press handler instead, as on GTK3: expand or collapse the cursor row when it has children, otherwise let GtkTreeView move the cursor. Assisted-by: Anthropic Claude Code (claude-opus-5-5[1m])
There was a problem hiding this comment.
🟡 Changes recommended
The corrected GTK4 keyboard behavior lacks regression coverage.
1 open finding
What changed in this PR
Updates GTK4 Tree keyboard handling so Left/Right expand or collapse parent rows before GtkTreeView processes cursor movement.
Changes:
- Removes ineffective GTK4 class-level key bindings.
- Handles Left/Right directly while preserving modifiers, RTL behavior, search input, and leaf navigation.
| File | Description |
|---|---|
Tree.java |
Implements GTK4 row expansion and collapse keyboard handling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Left and Right bindings added to the GtkTreeView class came after GtkTreeView's own move-cursor bindings, which handle the keys first, so they never ran. Handle the keys in the key press handler instead, as on GTK3: expand or collapse the cursor row when it has children, otherwise let GtkTreeView move the cursor.
Assisted-by: Anthropic Claude Code (claude-opus-5-5[1m])