Decompose checkInstanceLocation into focused helper methods#4146
Open
vogella wants to merge 1 commit into
Open
Decompose checkInstanceLocation into focused helper methods#4146vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
Member
|
Please keep all methods extracted from protected methods also protected, so they could be overriden if needed. |
Contributor
Extract the already-set lock handling, the prompt-retry loop, and the "workspace in use" dialog into lockExistingWorkspace, promptAndSetWorkspace, and openWorkspaceInUseDialog, leaving checkInstanceLocation as a short orchestrator. Pure extraction; behavior is unchanged.
vogella
force-pushed
the
refactor-checkinstancelocation
branch
from
08c2b7d to
8c6bfa3
Compare
Contributor
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the long
checkInstanceLocationmethod into a short orchestrator by extracting the already-set lock handling (lockExistingWorkspace), the prompt-retry loop (promptAndSetWorkspace), and the inline "workspace in use" dialog (openWorkspaceInUseDialog). Pure extraction, no behavior change. Stacked on #4140 (the two overlap in the same method), so this currently includes that commit as well; kept as a draft until #4140 merges, after which it rebases down to a single-commit extraction diff.