Repository navigation
Conversation
Contributor
Test Results 867 files 867 suites 43m 13s ⏱️ Results for commit d2252ee. ♻️ This comment has been updated with latest results. |
Contributor
Author
|
Before: 
After: 
|
vogella
marked this pull request as ready for review
September 1, 2026 15:27
vogella
force-pushed
the
ctabfolder-page-initial-styling
branch
2 times, most recently
from
September 3, 2026 11:15
e7045c4 to
9f90fae
Compare
Contributor
Author
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Deferred listeners need filtering and deduplication to avoid persistent or repeated resize handling.
Review effort: Balanced
Findings: 1
What changed in this PR
Fixes delayed CSS styling for hidden CTabFolder pages.
Changes:
- Defers styling until a hidden page becomes selected or attached.
- Adds regression tests for both page-creation sequences.
- Removes the obsolete
swt-simpletest.
| File | Description |
|---|---|
CSSSWTApplyStylesListener.java |
Adds deferred page styling listeners. |
CTabFolderTest.java |
Adds regression coverage and removes obsolete coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vogella
force-pushed
the
ctabfolder-page-initial-styling
branch
7 times, most recently
from
September 30, 2026 16:03
ec93fb9 to
8036197
Compare
vogella
force-pushed
the
ctabfolder-page-initial-styling
branch
3 times, most recently
from
October 7, 2026 05:56
e102dfd to
8a07003
Compare
vogella
force-pushed
the
ctabfolder-page-initial-styling
branch
from
October 8, 2026 12:34
8a07003 to
3d4d5c8
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Already-sized and reparented pages can still remain unstyled.
2 open findings
1 resolved since last review
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Comment on lines
+60
to
+70
| // the control may have been reparented, and a new skin event watches it again | ||
| boolean inFolder = control.getParent() == folder && !folder.isDisposed(); | ||
| if (inFolder && !isPageOfSelectedTab(folder, control)) { | ||
| return; | ||
| } | ||
| control.removeListener(SWT.Show, this); | ||
| control.removeListener(SWT.Resize, this); | ||
| control.setData(pendingPageKey, null); | ||
| if (inFolder) { | ||
| engine.applyStyles(control, true); | ||
| } |
The Search dialog opened unstyled until a tab was switched. A CTabFolder exposes only the page of its selected tab to the CSS engine, and applyStyles skips an element that is not visible. A page skinned while its tab is not selected, or before it is attached to its tab, as SearchDialog and its search pages do, is skipped, and neither the programmatic setSelection nor the attach sends a skin event that would restyle it. Watch such a page for the show or resize that makes it the selected tab's page and style it then. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
ctabfolder-page-initial-styling
branch
from
October 9, 2026 06:04
3d4d5c8 to
d2252ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Search dialog opens unstyled in the dark theme and only picks up the theme once a tab is switched. A CTabFolder exposed only the page of its selected tab to the CSS engine, so a page skinned before it was attached, or while its tab was not yet selected, was skipped, and neither attaching a page to the selected tab nor a programmatic setSelection fires an event that would style it later.
Now only the pages of unselected tabs are hidden from the engine, so a page no tab holds yet is styled as soon as it is skinned, and a skipped page of an unselected tab is styled on the Show event that selecting its tab always sends. This closes the case of an already sized, visible page attached to the selected tab without any further event, and the pages of unselected tabs are still skipped, so styling stays lazy.
New CTabFolderTest cases cover the dialog's sequences, a pre-sized page attached after pending paints are drained, toolbar pages, reparented pages, repeated re-skins and the still-deferred unselected page. The swt-simple test is dropped, since curved tabs are gone and getSimple() always returns true.