Repository navigation
WizardDialog resizes itself in an endless loop after a DPI change ecl… - #4428
Open
astrograph wants to merge 1 commit into
Open
astrograph wants to merge 1 commit into
astrograph wants to merge 1 commit into
Conversation
Contributor
astrograph
force-pushed
the
wizarddialog-resize-loop
branch
from
October 8, 2026 06:40
b3b863c to
5007d43
Compare
Member
|
@astrograph : we do not allow merge commits. Please update to latest master, cherry-pick your single commit with the fix and force push. |
astrograph
force-pushed
the
wizarddialog-resize-loop
branch
from
October 8, 2026 11:32
77c5495 to
883523e
Compare
…ipse-platform/eclipse.platform#2986 WizardDialog builds its shell with SWT.RESIZE but inherits isResizable() == false from Dialog, so hookZoomChangeListenerForDefaultSizedDialogs() installs adaptDefaultSizeListener on every wizard. That listener calls shell.setSize(shell.computeSize(...)), which sends the next SWT.Resize, and it has no re-entrancy guard: whenever the computed size is not a fixed point the listener recurses until the stack is exhausted. Let WizardDialog report the SWT.RESIZE bit of its shell style, and make the listener skip a nested call and a size that has not changed. Fixes eclipse-platform/eclipse.platform#2986 Signed-off-by: Philipp SALZGEBER <Philipp.SALZGEBER@bachmann.info>
astrograph
force-pushed
the
wizarddialog-resize-loop
branch
from
October 8, 2026 14:35
ddb37eb to
357c597
Compare
|
Hi @astrograph — thank you for your contribution! The Eclipse Contributor Agreement (ECA) check has failed for this pull request for the following reason(s):
To resolve this, please:
Once done, push a new commit (or rebase) to re-trigger the ECA validation. If you believe you've already completed these steps, please double-check your account settings or report an issue to the Eclipse Foundation Helpdesk. Thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ipse-platform/eclipse.platform#2986
WizardDialog builds its shell with SWT.RESIZE but inherits isResizable() == false from Dialog, so hookZoomChangeListenerForDefaultSizedDialogs() installs adaptDefaultSizeListener on every wizard. That listener calls shell.setSize(shell.computeSize(...)), which sends the next SWT.Resize, and it has no re-entrancy guard: whenever the computed size is not a fixed point the listener recurses until the stack is exhausted.
Let WizardDialog report the SWT.RESIZE bit of its shell style, and make the listener skip a nested call and a size that has not changed.
Fixes eclipse-platform/eclipse.platform#2986