Repository navigation
Conversation
Contributor
The POST_CHANGE event of the import can still be pending in the workspace notification job when SmartImportJob.run returns, so the test occasionally counted 0 events. A checkpoint delivers it before the assertion. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
lv/smartimport-single-operation-flake
branch
from
October 7, 2026 10:41
587fa66 to
81d7c38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SmartImportTests.testProjectsAreCreatedInASingleWorkspaceOperationoccasionally fails withexpected:<1> but was:<0>, for example on the CI of #4226. When another thread has a workspace operation open as the import ends, the workspace defers the POST_CHANGE broadcast to its notification job, so the event can still be pending whenSmartImportJob.runreturns. The test now callscheckpoint(false)before counting, which delivers the pending delta while still failing if the import creates its projects in several operations.