Use ILog instead of CompareUIPlugin logging helpers#2790
Closed
vogella wants to merge 1 commit into
Closed
Conversation
Replace the static CompareUIPlugin.log/logErrorMessage helpers with org.eclipse.core.runtime.ILog at all call sites and remove the helpers. Severity and messages are preserved. This removes logging from the CompareUIPlugin activator and its getDefault() singleton dependency.
Contributor
|
This actually looks more verbose, so an advantage seems unclear to me. Also the log call needs to look up the bundle form the class so this will perform less well, not that it really much matters. But in the end, I don't see the motivation nor advantage here. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the static
CompareUIPlugin.log/logErrorMessagehelpers withorg.eclipse.core.runtime.ILogat every call site inorg.eclipse.compareand removes the three helpers.Severity and messages are preserved, so there is no behavior change; it just moves logging off the
CompareUIPluginactivator and drops one more use of thegetDefault()singleton.All call sites in the bundle were migrated and the bundle compiles cleanly.