Cleanup ProcessConsoleManager implementation#2810
Merged
iloveeclipse merged 1 commit intoJul 10, 2026
Merged
Conversation
- read extension registry only once, on startup, remove unneeded locks - get rid of shared `fDefaultColorProvider` which can't work per design Fixes eclipse-platform#2638 Fixes eclipse-platform#2637
This was referenced Jul 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Debug UI ProcessConsoleManager to eliminate races caused by lazy extension initialization and by sharing a single default ConsoleColorProvider across consoles.
Changes:
- Initialize console color providers and line tracker extension caches eagerly (once) during
ProcessConsoleManagerconstruction. - Remove shared
fDefaultColorProviderand return a fresh defaultConsoleColorProviderwhen no contributed provider matches. - Simplify internal state by making caches/maps
finaland removing now-unneeded locking/nullable map patterns.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fDefaultColorProviderwhich can't work per designFixes #2638
Fixes #2637