Repository navigation
Remove try/catch workaround in BreakpointLabelAction - #3001
Open
ravnskjaer wants to merge 1 commit into
Open
ravnskjaer wants to merge 1 commit into
ravnskjaer wants to merge 1 commit into
Conversation
The workaround in computeInlineEditorBounds() caught the ArrayIndexOutOfBoundsException thrown by TreeItem.getBounds() on macOS. That exception is fixed in SWT by eclipse-platform/eclipse.platform.swt#3628 (included in I-builds from I20261007-2300 onwards), so the workaround is no longer needed. Follow-up to eclipse-platform/eclipse.platform.swt#2749
SougandhS
reviewed
Oct 9, 2026
| @@ -112,27 +112,11 @@ public void keyPressed(KeyEvent e) { | |||
|
|
|||
| private static Rectangle computeInlineEditorBounds(TreeItem treeItem) { | |||
| Rectangle bounds; | |||
Contributor
There was a problem hiding this comment.
Please inline this variable
Suggested change
| Rectangle bounds; | |
| Rectangle bounds = treeItem.getBounds(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to eclipse-platform/eclipse.platform.swt#3628, which fixes eclipse-platform/eclipse.platform.swt#2749.
Removes the try/catch workaround in
BreakpointLabelAction.computeInlineEditorBounds(), which is no longer needed now thatTreeItem.getBounds()no longer throws on Cocoa.Verified manually on macOS Tahoe 26.6.2 (Apple M1) with SWT containing eclipse-platform/eclipse.platform.swt#3628: editing a breakpoint label with a custom font works without the workaround.