Repository navigation
Conversation
…nd-sheetcut-validator
mariusheine
requested changes
Oct 8, 2026
…ub.com/linusbbb/set into siteplan-export-and-sheetcut-validator
…e/set/ppmodel/extensions/utils/PlanProToTitleboxTransformation.xtend Co-authored-by: TruongQuangSB <131350493+TruongQuangSB@users.noreply.github.com>
…ub.com/linusbbb/set into siteplan-export-and-sheetcut-validator
TruongQuangSB
requested changes
Oct 13, 2026
Comment on lines
+71
to
+107
| final PlanProXMLNode node = nodeFinder.find(sheetCut); | ||
| final int line = node == null ? 0 | ||
| : nodeFinder.getLineNumber(node); | ||
| final String objektArt = nodeFinder.getObjectType(node); | ||
|
|
||
| final Polygonzug_Ausrichtung_TypeClass ausrichtung = sheetCut | ||
| .getPolygonzugAusrichtung(); | ||
| final PlanProXMLNode ausrichtungsNode = nodeFinder | ||
| .find(ausrichtung); | ||
| final int ausrichtungsLine = ausrichtungsNode == null ? line | ||
| : nodeFinder.getLineNumber(ausrichtungsNode); | ||
|
|
||
| final String wert = ausrichtung == null ? null | ||
| : ausrichtung.getWert(); | ||
| if (wert == null || wert.isBlank()) { | ||
| anyProblems = true; | ||
| final CustomValidationProblemImpl problem = new CustomValidationProblemImpl( | ||
| "Blattschnitt ohne Ausrichtung", //$NON-NLS-1$ | ||
| ValidationSeverity.WARNING, | ||
| this.validationType(), objektArt, null, null); | ||
| problem.setLineNumber(ausrichtungsLine); | ||
| result.addCustomProblem(problem); | ||
| } else { | ||
| final String[] tokens = wert.trim().split("\\s+"); //$NON-NLS-1$ | ||
| if (tokens.length != 4) { | ||
| anyProblems = true; | ||
| final CustomValidationProblemImpl problem = new CustomValidationProblemImpl( | ||
| String.format( | ||
| "Ausrichtung hat %d Koordinaten (erwartet 4)", //$NON-NLS-1$ | ||
| Integer.valueOf(tokens.length)), | ||
| ValidationSeverity.WARNING, | ||
| this.validationType(), objektArt, null, | ||
| null); | ||
| problem.setLineNumber(ausrichtungsLine); | ||
| result.addCustomProblem(problem); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
@linusbbb For better readability and easier debugging, consider extracting this validation into a separate method, such as validateDirectionLine.
| problem.setLineNumber(ausrichtungsLine); | ||
| result.addCustomProblem(problem); | ||
| } else { | ||
| final String[] tokens = wert.trim().split("\\s+"); //$NON-NLS-1$ |
Contributor
There was a problem hiding this comment.
@linusbbb the coordinaten string should also check, if this a number
| } | ||
| } | ||
|
|
||
| if (!anyProblems) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!anyProblems) { | |
| if (result.isEmpty()) { |
@linusbbb you can simple check if the list empty or not, when empty, then that mean no error
Comment on lines
+109
to
+153
| final Polygonzug_Blattschnitt_TypeClass polygon = sheetCut | ||
| .getPolygonzugBlattschnitt(); | ||
| final PlanProXMLNode polygonNode = nodeFinder.find(polygon); | ||
| final int polygonLine = polygonNode == null ? line | ||
| : nodeFinder.getLineNumber(polygonNode); | ||
|
|
||
| final String polygonWert = polygon == null ? null | ||
| : polygon.getWert(); | ||
| if (polygonWert == null || polygonWert.isBlank()) { | ||
| anyProblems = true; | ||
| final CustomValidationProblemImpl problem = new CustomValidationProblemImpl( | ||
| "Blattschnitt ohne Polygon", //$NON-NLS-1$ | ||
| ValidationSeverity.WARNING, | ||
| this.validationType(), objektArt, null, null); | ||
| problem.setLineNumber(polygonLine); | ||
| result.addCustomProblem(problem); | ||
| } else { | ||
| final String[] polygonTokens = polygonWert.trim() | ||
| .split("\\s+"); //$NON-NLS-1$ | ||
| if (polygonTokens.length % 2 != 0) { | ||
| anyProblems = true; | ||
| final CustomValidationProblemImpl problem = new CustomValidationProblemImpl( | ||
| String.format( | ||
| "Polygon hat %d Koordinaten (ungerade Anzahl)", //$NON-NLS-1$ | ||
| Integer.valueOf( | ||
| polygonTokens.length)), | ||
| ValidationSeverity.WARNING, | ||
| this.validationType(), objektArt, null, | ||
| null); | ||
| problem.setLineNumber(polygonLine); | ||
| result.addCustomProblem(problem); | ||
| } else if (polygonTokens.length / 2 < 3) { | ||
| anyProblems = true; | ||
| final CustomValidationProblemImpl problem = new CustomValidationProblemImpl( | ||
| String.format( | ||
| "Polygon hat %d Punkte, mindestens 3 erforderlich", //$NON-NLS-1$ | ||
| Integer.valueOf( | ||
| polygonTokens.length / 2)), | ||
| ValidationSeverity.WARNING, | ||
| this.validationType(), objektArt, null, | ||
| null); | ||
| problem.setLineNumber(polygonLine); | ||
| result.addCustomProblem(problem); | ||
| } | ||
| } |
Comment on lines
+71
to
+84
| final PlanProXMLNode node = nodeFinder.find(sheetCut); | ||
| final int line = node == null ? 0 | ||
| : nodeFinder.getLineNumber(node); | ||
| final String objektArt = nodeFinder.getObjectType(node); | ||
|
|
||
| final Polygonzug_Ausrichtung_TypeClass ausrichtung = sheetCut | ||
| .getPolygonzugAusrichtung(); | ||
| final PlanProXMLNode ausrichtungsNode = nodeFinder | ||
| .find(ausrichtung); | ||
| final int ausrichtungsLine = ausrichtungsNode == null ? line | ||
| : nodeFinder.getLineNumber(ausrichtungsNode); | ||
|
|
||
| final String wert = ausrichtung == null ? null | ||
| : ausrichtung.getWert(); |
Contributor
There was a problem hiding this comment.
@linusbbb u can use org.eclipse.set.ppmodel.extensions.EObjectExtensions.getNullableObject(sheetcut, s -> s.getPolygonzugAusrichtung().getWert()) to avoid more times null check
| "Blattschnitt ohne Ausrichtung", //$NON-NLS-1$ | ||
| ValidationSeverity.WARNING, | ||
| this.validationType(), objektArt, null, null); | ||
| problem.setLineNumber(ausrichtungsLine); |
Contributor
There was a problem hiding this comment.
@linusbbb when it is missing the information, then don't need define the linenumber
Comment on lines
+126
to
+127
| final String[] polygonTokens = polygonWert.trim() | ||
| .split("\\s+"); //$NON-NLS-1$ |
Contributor
There was a problem hiding this comment.
@linusbbb like oben, the polygon coordinate should be also validate
…e/set/ppmodel/extensions/utils/PlanProToTitleboxTransformation.xtend Co-authored-by: TruongQuangSB <131350493+TruongQuangSB@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.