Conversation
The Win32 VS 2019 port has an include directory but no CMakeLists.txt, which prevents FileX from being consumed as a CMake dependency. Wire the header-only port into the build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Assisted-by: Codex (gpt-5.6-sol) <codex@openai.com>
Removed a stray copyright line from the version initializer, corrected the copyright year, and aligned the Win32 version string with the target release. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Assisted-by: Codex (gpt-5.6-sol) <codex@openai.com>
Regenerated the Win32 port header with regression hooks, aligned MSVC large-buffer declarations, enabled large-address-aware Win32 test executables, and corrected the default ThreadX path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Assisted-by: Codex (gpt-5.6-sol) <codex@openai.com>
Guarded fault-tolerant standalone buffers so non-fault-tolerant MSVC configurations do not declare zero-length arrays. Assisted-by: Codex (gpt-5.6-sol) <codex@openai.com>
Assisted-by: Codex (gpt-5.6-sol) <codex@openai.com>
Assisted-by: Codex (gpt-5.6-sol) <codex@openai.com>
Assisted-by: Codex (gpt-5.6-sol) <codex@openai.com>
Contributor
|
LGTM 👍 |
The branch added the older per-edit disclosure, which names the product and the
model version. That form accumulates: a second agent, or the same agent on a
newer model, appends another line rather than recognising the one already there,
and the spelling drifts with every release.
All 10 lines become the fixed text, written with the comment character each file
uses -- `//` in C sources and headers, `#` in CMakeLists and PowerShell:
Portions of this file were generated with AI assistance.
Attribution for the change itself stays on the commit, in the Assisted-by
trailer. The AI Disclosure headers on the files this branch creates are
unchanged, and keep naming their product and model: a file is created once, so
that record cannot grow.
Comment-only, one line replaced per file, no file left with zero or more than
one. The new-file AI Disclosure headers are untouched.
Assisted-by: Claude Code (Opus 5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refresh incorporates all useful work from the historical
windows-sim-ports-completionbranch; all four of that branch's patches are patch-equivalent here, so no legacy change remains to salvage.Depends on eclipse-threadx/threadx#736.
Validation
All builds used CMake and Ninja with MSVC and the ThreadX branch from eclipse-threadx/threadx#736. Tests ran serially with failed-test retry enabled, including the long fault-tolerance cases.
Notes