Conversation
Fixes eclipse-threadx#81 A NAND geometry with too few pages can format successfully, then enter another metadata allocation while rebuilding a snapshot later. Format and open now reject geometries unless the snapshot, a block-link page, and one later update fit in one block. The check returns LX_NOT_SUPPORTED before LevelX flash I/O. The host test uses printf and exit to report to CTest; these are test-only exceptions to MISRA C:2004 Rules 20.9 and 20.11 and MISRA C:2012/2023 Rules 21.6 and 21.8. GCC 14 CMake/Ninja: 4/4 focused configurations and the existing NAND regression passed. New validation lines and branches: 14/14 each. No hardware test. Assisted-by: Codex (GPT-6-Sol) <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81
A NAND geometry with too few pages can format successfully, then enter another metadata allocation while rebuilding a snapshot later.
Format and open now reject geometries unless the snapshot, a block-link page, and one later update fit in one block. The check returns LX_NOT_SUPPORTED before LevelX flash I/O. The host test uses printf and exit to report to CTest; these are test-only exceptions to MISRA C:2004 Rules 20.9 and 20.11 and MISRA C:2012/2023 Rules 21.6 and 21.8. The capacity check does not address the existing open-path rejection of partially filled final metadata-table pages. @rahmanih, please review this approach; I am happy to change it if you disagree.
GCC 14 CMake/Ninja: 4/4 focused configurations and the existing NAND regression passed. New validation lines and branches: 14/14 each. No hardware test.