Cancel pool connection timeout timer when acquisition fails - #1712
Open
goutamadwant wants to merge 2 commits into
Open
goutamadwant wants to merge 2 commits into
goutamadwant wants to merge 2 commits into
Conversation
See eclipse-vertx#1706 When a pooled query fails to acquire a connection, the connection timeout timer is not cancelled, so it fails the query handler a second time when it fires. When the timer fires first, the acquisition failure also fails the handler again. Handle the acquisition failure like a successful acquisition: cancel the timer, and if it already fired, do not complete the handler again. Signed-off-by: Goutam Adwant <workwithgoutam@gmail.com>
vietj
reviewed
Sep 28, 2026
| dequeueMetric(metric); | ||
| if (timerId != -1 && !vertx.cancelTimer(timerId)) { | ||
| // The timer already failed the handler | ||
| return Future.failedFuture(POOL_QUERY_TIMEOUT_EXCEPTION); |
Member
There was a problem hiding this comment.
can you make it an if/else instead ?
Signed-off-by: Goutam Adwant <workwithgoutam@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Fixes #1706
When the pool fails to acquire a connection,
SqlConnectionPool.executeleaves the connection-timeout timer armed, so the query handler is completed twice:Timeout waiting for connection.Changes:
Tests (no database needed):
DriverBaseTest.testConnectFailureCancelsPoolConnectionTimeoutDriverBaseTest.testConnectFailureAfterPoolConnectionTimeoutConformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines