[GEF] Remove redundant Handle class#1565
Open
ptziegler wants to merge 1 commit into
Open
Conversation
Test Results 4 files ±0 4 suites ±0 2h 14m 40s ⏱️ - 3m 11s For more details on these failures, see this check. Results for commit 4f4c8e5. ± Comparison against base commit 9813125. ♻️ This comment has been updated with latest results. |
Extend the GEF `AbstractHandle` class directly. The `Handle` class is renamed to `DesignHandle`, because WindowBuilder sub-classes it twice. Note that now the handlers are relocated in the `validate()` method, which is executed asynchronously in the UI thread and must therefore be explicitly called in our integration tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the GEF
AbstractHandleclass directly. TheHandleclass is renamed toDesignHandle, because WindowBuilder sub-classes it twice.