Repository navigation
update to vuetify 4.1.8 - #2649
Closed
margioriev wants to merge 1 commit into
Closed
margioriev wants to merge 1 commit into
margioriev wants to merge 1 commit into
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Margiorie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
margioriev
marked this pull request as draft
October 14, 2026 21:23
Contributor
|
Hi @margioriev , thanks for the (draft) contribution. Note that there is already an open PR to upgrade to Vuetify 4: |
Contributor
|
Hi @margioriev , thank you very much for the contribution ❤️ . I am closing this because #2638 also update to Vuetify 4 and is close to merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@jsonforms/vue-vuetifynow requires Vuetify ^4.1.8. The previous peer was ^3.11.0. The lower bound has to rise because Vuetify 4 removedvuetify/labs/VStepperVertical. Applications that must stay on Vuetify 3 should stay on the current JSON Forms release.Implementation Details
vuetifypeer dependency and dev dependency both move from^3.11.0to^4.1.8.CategorizationStepperRendererimportsVStepperVerticalandVStepperVerticalItemfromvuetify/components/VStepperVertical. That was the onlyvuetify/labsimport in the package.vuetify@4.2.5. pnpm 11.27.1 also records the optionalsupports-colorpeer on existing snapshot ids. Those package versions are unchanged.Files
packages/vue-vuetify/package.json: sets thevuetifypeer dependency and the dev dependency from^3.11.0to^4.1.8.packages/vue-vuetify/src/layouts/CategorizationStepperRenderer.vue: importsVStepperVerticalandVStepperVerticalItemfromvuetify/components/VStepperVerticalinstead ofvuetify/labs/VStepperVertical.pnpm-lock.yaml: resolvesvuetify@4.2.5, pointsvite-plugin-vuetifyat that version, and adds@vuetify/v0. The remaining hunks append(supports-color@8.1.1)to snapshot ids that were already present.Snapshots
These files only record the HTML Vuetify 4 renders. No spec logic changed.
packages/vue-vuetify/tests/unit/additional/__snapshots__/ListWithDetailRenderer.spec.ts.snap:v-rowgainsv-row--density-default.packages/vue-vuetify/tests/unit/complex/__snapshots__/ArrayControlRenderer.spec.ts.snap: the progress bar gains--v-progress-reveal-durationand--v-progress-chunk-gap. The row gainsv-row--density-defaultandjustify--center.packages/vue-vuetify/tests/unit/complex/__snapshots__/MultiEnumSelectRenderer.spec.ts.snap: the select gainsv-input--indent-details, and the progress bar gains the two CSS variables above.packages/vue-vuetify/tests/unit/complex/__snapshots__/OneOfRenderer.spec.ts.snap: the select gainsv-input--indent-details, and the progress bar gains those CSS variables.packages/vue-vuetify/tests/unit/controls/__snapshots__/DateControlRenderer.spec.ts.snap: the text field gainsv-input--indent-details, and the progress bar gains those CSS variables.packages/vue-vuetify/tests/unit/controls/__snapshots__/DateTimeControlRenderer.spec.ts.snap: the text field gainsv-input--indent-details, and the progress bar gains those CSS variables.packages/vue-vuetify/tests/unit/controls/__snapshots__/EnumControlRenderer.spec.ts.snap: the select gainsv-input--indent-details, and the progress bar gains those CSS variables.packages/vue-vuetify/tests/unit/controls/__snapshots__/IntegerControlRenderer.spec.ts.snap: the number input gainsv-input--indent-details, and the progress bar gains those CSS variables.packages/vue-vuetify/tests/unit/controls/__snapshots__/MultiStringControlRenderer.spec.ts.snap: the textarea gainsv-input--indent-details, and the progress bar gains those CSS variables.packages/vue-vuetify/tests/unit/controls/__snapshots__/NumberControlRenderer.spec.ts.snap: the number input gainsv-input--indent-details, and the progress bar gains those CSS variables.packages/vue-vuetify/tests/unit/controls/__snapshots__/OneOfEnumControlRenderer.spec.ts.snap: the select gainsv-input--indent-details, and the progress bar gains those CSS variables.packages/vue-vuetify/tests/unit/controls/__snapshots__/StringControlRenderer.spec.ts.snap: the text field and the combobox gainv-input--indent-details, and the progress bar gains those CSS variables.packages/vue-vuetify/tests/unit/controls/__snapshots__/TimeControlRenderer.spec.ts.snap: the text field gainsv-input--indent-details, and the progress bar gains those CSS variables.packages/vue-vuetify/tests/unit/layout/__snapshots__/ArrayLayoutRenderer.spec.ts.snap: the progress bar gains those CSS variables. The row gainsv-row--density-defaultandjustify--center.How to Test
pnpm install && pnpm --filter @jsonforms/vue-vuetify build.pnpm --filter @jsonforms/vue-vuetify test.Use this branch in another project
Clone only
update-jsonforms-vue-vuetify-to-vuetify4:git clone --single-branch --branch update-jsonforms-vue-vuetify-to-vuetify4 git@github.com:margioriev/jsonforms.git cd jsonformsThis repo needs Node 24 and pnpm 11.
node -vmust printv24.xbefore the install.libis not in git, so the packages have to be built before they can be imported.Publish the three built packages to the local yalc store:
In the application where you want to use this package, install Vuetify 4 and link the packages:
@jsonforms/vue-vuetifyrequires@jsonforms/coreand@jsonforms/vueat3.9.0-alpha.1,vueat^3.5.0, andvuetifyat^4.1.8. Take all three JSON Forms packages from this branch.