Repository navigation
Conversation
- Add --url (falls back to AMP_QUERY_URL, then http://localhost:1602); grpc:// and grpc+tls:// are accepted alongside http(s):// - Fall back to AMP_AUTH_TOKEN when --token is not passed - Print why a query failed instead of exiting 1 silently - Add a `pnpm amp` script and a getting-started README Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amp queryhadhttp://localhost:1602hardcoded, so the CLI couldn't query staging or any other remote server. It also exited 1 with no output on any failure.--url/-ufalls back toAMP_QUERY_URL, then tohttp://localhost:1602. It acceptsgrpc://andgrpc+tls://(as used by ampd, ampsql and amp-python) as well ashttp(s)://.--tokennow falls back toAMP_AUTH_TOKEN, then to the cached login as before.Query failed: [unauthenticated] Jwt is missingorQuery failed: [unavailable] connect ECONNREFUSED 127.0.0.1:1602.pnpm ampscript runs the CLI from source with--experimental-transform-types. The generated protobuf enums need that flag. Building doesn't help, because inside the workspace@edgeandnode/ampstill resolves tosrc/*.ts.@edgeandnode/ampon npm (0.0.55) is the older SDK fromedgeandnode/amp.Not changed:
auth.amp.thegraph.com(used byamp auth login) serves an expired certificate, and I couldn't find a replacement host.Testing
pnpm check:tsgo,pnpm lintandpnpm circularpass;pnpm test: 233 passed.Authorizationheader against a local stub server.AMP_AUTH_TOKEN.🤖 Generated with Claude Code