fix(e2e): run complete CLI package - #65
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 28 28
Lines 712 712
=======================================
Hits 573 573
Misses 96 96
Partials 43 43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the complete
cmd/gh-md-tocpackage in the Makefile e2e commands instead of compiling onlymain.go.Regression source
The regression was introduced in PR #60.
That PR moved CLI configuration and
parseConfigfrommain.gointo a separateconfig.gofile. The Makefile continued to execute:Running a specific Go file compiles only that file, so
config.gowas excluded and every e2e command failed with:The issue was discovered while validating PR #64 and is intentionally fixed in this separate PR.
Fix
Update all three e2e command variables to run the complete CLI package:
This includes every Go file in
cmd/gh-md-toc, includingmain.goandconfig.go.The change covers:
Verification
make e2epasses all nine scenarios:All generated results match the existing golden files.