fix: fail fast when opfs-ahp pool handles cannot be opened - #1064
Open
AntonOfTheWoods wants to merge 1 commit into
Open
fix: fail fast when opfs-ahp pool handles cannot be opened#1064AntonOfTheWoods wants to merge 1 commit into
AntonOfTheWoods wants to merge 1 commit into
Conversation
The pool-handle open in #init and both maintainPool loops used async promise executors with no rejection path — any getFileHandle or createSyncAccessHandle throw became an unhandled rejection and Promise.all never settled, so a broken pool wedged database startup silently and forever (observed in the field on headed Chrome and Safari). Convert the three sites to proper async helpers whose errors propagate as a catchable error naming the failing operation and filename, with the original error preserved as `cause`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pool-handle open in #init and both maintainPool loops used async promise executors with no rejection path — any getFileHandle or createSyncAccessHandle throw became an unhandled rejection and Promise.all never settled, so a broken pool wedged database startup silently and forever (observed in the field on headed Chrome and Safari).
Convert the three sites to proper async helpers whose errors propagate as a catchable error naming the failing operation and filename, with the original error preserved as
cause.This covers both the safari 252 opfs limit and the linux chromium default soft limit of 1024 which gets exhausted now by initdb's ~970 open files.