Repository navigation
ci: bump secret-service-action to v1.1.0 - #237
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ELojQikqpZ2KVGqjEeNwUe
Contributor
Author
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. This action fetches the release job's GitHub token, so it would be worth having a human confirm the new pinned SHA before merging.
What was reviewed:
- The one-line change in
.github/workflows/release.yml: thesecret-servicestep moves from3476425…(v1.0.0) to23b9042…(v1.1.0). It is still pinned to a full SHA with a version comment, and no inputs were added. - The next step still reads
fromJSON(steps.secret-service.outputs.secrets).GITHUB_TOKEN, so v1.1.0 has to keep thatsecretsoutput shape. - I couldn't check from this checkout whether
23b9042…really is the upstream v1.1.0 tag of electron/secret-service-action.
Extended reasoning...
The change bumps the pinned SHA of electron/secret-service-action in the release workflow, a single line. The step it changes fetches the secrets, including the GitHub token, that semantic-trusted-release uses to publish. That job runs with id-token: write in the npm-trusted-publisher environment. CODEOWNERS assigns every path to a code-owner team, and I couldn't confirm the new SHA against the upstream tag, so I'm deferring instead of approving.
MarshallOfSound
approved these changes
Oct 22, 2026
MarshallOfSound
enabled auto-merge (squash)
October 22, 2026 21:42
jkleinsc
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
Bumps secret-service-action to v1.1.0, which points the secret exchange at secret-service's new home on ionic (secret-service.electronjs.org) instead of Heroku.
Generated by Claude Code