Greeter: avoid early authentication#885
Draft
lenemter wants to merge 1 commit into
Draft
Conversation
Member
Author
|
Converting to draft to think about how this will affect fingerprint auth |
Member
Hi! I think you can go ahead with this PR and not worry about fprint auth which is already currently quite broken. As long as a user can still add the fprintd PAM config and "somewhat" login with their fprint in this PR we should be good IMO. My PR #884 to address/workaround fprint auth/login to get it in an acceptable condition I can rework the code after your PRs get merged, it's a small diff anyway, assuming reviewers don't raise concerns with the approach. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #413
Current workflow in main is "carousel page switched" -> "authenticate by username" -> "wait for password" -> "respond with password". But when a user has no password set,
LightDM.Greeter.authenticate (username)logs the user in without the need to provide the credential viaLightDM.Greeter.respond (credential).This PR changes workflow to "Wait for a card to call
authenticatewith username and credential" -> "authenticate" -> "respond"Also I put this logic into a separate class since
MainWindow.valais very long and it's very hard to read code there.