AliasDialog: use ListStore - #1082
Merged
Merged
Conversation
jeremypw
requested changes
Aug 8, 2026
jeremypw
left a comment
jeremypw
left a comment
Contributor
There was a problem hiding this comment.
Couple of inline comments. Also clicking on the add button does nothing. Investigating.
| list.set_filter_func ((Gtk.ListBoxFilterFunc) filter_func); | ||
| list.set_placeholder (placeholder); | ||
| list_box.bind_model (alias_list, (obj) => (Alias) obj); | ||
| list_box.set_filter_func ((Gtk.ListBoxFilterFunc) filter_func); |
Contributor
There was a problem hiding this comment.
I think filter functions are ignored when there is a bound model.
Member
Author
|
@jeremypw oops sorry about that. Should work now |
jeremypw
approved these changes
Aug 10, 2026
jeremypw
left a comment
jeremypw
left a comment
Contributor
There was a problem hiding this comment.
Looks good now and seems to work.
| write_aliases (); | ||
| }); | ||
|
|
||
| list.add (alias); |
Contributor
There was a problem hiding this comment.
You need to replace this with somthing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't use
get_childrenin GTK4, so use a ListStore