Internal: Consolidate Hello theme release into Deploy workflow - #684
Closed
Ntnelbaba wants to merge 4 commits into
Closed
Internal: Consolidate Hello theme release into Deploy workflow#684Ntnelbaba wants to merge 4 commits into
Ntnelbaba wants to merge 4 commits into
Conversation
Make deploy.yml the single stable release entry point with input-driven semver validation, version bumps, build, force-with-lease push to main, GitHub release, WordPress.org SVN publish, and Slack notification. Co-authored-by: Cursor <cursoragent@cursor.com>
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
| node ./.github/scripts/get-changelog-from-readme-txt.js | ||
|
|
||
| - name: Create GitHub release | ||
| uses: softprops/action-gh-release@v1 |
Co-authored-by: Cursor <cursoragent@cursor.com>
Hello Elementor BuildLast updated at: 20260819.1232 ✅ Hello Elementor build is ready for download. You can download the latest build from the link below: The build is available for 7 days. |
Local composite actions require the repository on disk before they can run. Co-authored-by: Cursor <cursoragent@cursor.com>
Checkout main for theme files but restore .github from the workflow ref so pre-merge Deploy runs can use the new release scripts. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy.ymlinto the single stable release entry point: permissions check, SemVer validation, version bump, build, force-with-lease push tomain, GitHub release, WordPress.org SVN publish, and Slack notificationDEPLOYMENT_PERMITTED_USERSrepo variablepublish-release,publish-beta,publish-patch), orphaned release scripts, and unused composite actionsupdate-version-in-files.jsto updatestyle.css(the actual version source) instead of a non-existent SCSS fileTest plan
validate-release-version.shaccepts3.4.10and rejects equal, lower, beta, and malformed inputsnpm version+ file updater +validate-versions-release.sh) passes locally.github/deploy.ymlYAML validatesDEPLOYMENT_PERMITTED_USERSrepo variable before first production deploy run✨ PR Description
1. Problem & Context
Consolidating Hello theme release into a single Deploy workflow by removing the separate build job dependency and inline all release orchestration steps. Eliminates artifact passing complexity and centralizes version validation/deployment logic.
2. What Changed (Where)
.github/workflows/deploy.yml.github/scripts/update-version-in-files.js./assets/scss/style.scssto./style.css.github/scripts/validate-release-version.sh.github/scripts/commit-push-release-to-main.sh.github/workflows/permissions/action.yml.github/workflows/build.yml3. How It Works
Workflow triggers on manual dispatch → validates SemVer input and version increment → bumps package.json and updates version strings in source files (package.json, functions.php, readme.txt, style.css) → commits to main with force-with-lease safety → creates GitHub release → SNS notification. Permissions check gates execution to authorized users/repos.
4. Risks
Deleted build.yml workflow: Verify no other workflows depend on it as reusable. Force-push to main: Lease-SHA mitigates, but requires strict coordination; if MAIN_LEASE_SHA stale, push silently fails. Skipped SVN publish: Commented out; re-enabling requires testing. File path change (scss→css): Ensure style.css exists and contains version headers in expected format.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how