Skip to content

Internal: Consolidate Hello theme release into Deploy workflow - #684

Closed
Ntnelbaba wants to merge 4 commits into
mainfrom
internal/deploy-only-hello-release
Closed

Internal: Consolidate Hello theme release into Deploy workflow#684
Ntnelbaba wants to merge 4 commits into
mainfrom
internal/deploy-only-hello-release

Conversation

@Ntnelbaba

@Ntnelbaba Ntnelbaba commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Refactored deploy.yml into the single stable release entry point: permissions check, SemVer validation, version bump, build, force-with-lease push to main, GitHub release, WordPress.org SVN publish, and Slack notification
  • Added Elementor-style deploy permissions guard via DEPLOYMENT_PERMITTED_USERS repo variable
  • Removed legacy publish workflows (publish-release, publish-beta, publish-patch), orphaned release scripts, and unused composite actions
  • Fixed update-version-in-files.js to update style.css (the actual version source) instead of a non-existent SCSS file

Test plan

  • validate-release-version.sh accepts 3.4.10 and rejects equal, lower, beta, and malformed inputs
  • Full bump flow (npm version + file updater + validate-versions-release.sh) passes locally
  • No dead references under .github/
  • deploy.yml YAML validates
  • Create DEPLOYMENT_PERMITTED_USERS repo variable before first production deploy run
  • Dry-run Deploy workflow on a test version after merge (requires secrets + repo variable)

✨ PR Description

1. Problem & Context

Consolidating Hello theme release into a single Deploy workflow by removing the separate build job dependency and inline all release orchestration steps. Eliminates artifact passing complexity and centralizes version validation/deployment logic.

2. What Changed (Where)

File Change
.github/workflows/deploy.yml Replaced multi-job pipeline (validate→build→deploy) with single release job; added version validation, bumping, file updates, Git ops, and GitHub release creation
.github/scripts/update-version-in-files.js Changed target from ./assets/scss/style.scss to ./style.css
.github/scripts/validate-release-version.sh New: SemVer validation, version increment check, tag existence check
.github/scripts/commit-push-release-to-main.sh New: Commits version changes and force-pushes to main with lease
.github/workflows/permissions/action.yml New: Reusable permission validation for environment-gated deployments
.github/workflows/build.yml Deleted: Build action no longer needed in consolidated flow

3. How It Works

Workflow triggers on manual dispatch → validates SemVer input and version increment → bumps package.json and updates version strings in source files (package.json, functions.php, readme.txt, style.css) → commits to main with force-with-lease safety → creates GitHub release → SNS notification. Permissions check gates execution to authorized users/repos.

4. Risks

Deleted build.yml workflow: Verify no other workflows depend on it as reusable. Force-push to main: Lease-SHA mitigates, but requires strict coordination; if MAIN_LEASE_SHA stale, push silently fails. Skipped SVN publish: Commented out; re-enabling requires testing. File path change (scss→css): Ensure style.css exists and contains version headers in expected format.

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

Make deploy.yml the single stable release entry point with input-driven
semver validation, version bumps, build, force-with-lease push to main,
GitHub release, WordPress.org SVN publish, and Slack notification.

Co-authored-by: Cursor <cursoragent@cursor.com>
@wiz-9a149474ff

wiz-9a149474ff Bot commented Aug 19, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations 1 Low
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio.

node ./.github/scripts/get-changelog-from-readme-txt.js

- name: Create GitHub release
uses: softprops/action-gh-release@v1
Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown

Hello Elementor Build

Last updated at: 20260819.1232
Version: 3.4.9

✅ Hello Elementor build is ready for download.

You can download the latest build from the link below:

🔗 hello-elementor.3.4.9.zip

The build is available for 7 days.

Local composite actions require the repository on disk before they can run.

Co-authored-by: Cursor <cursoragent@cursor.com>
Checkout main for theme files but restore .github from the workflow ref
so pre-merge Deploy runs can use the new release scripts.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants