Internal: Clean up unused GitHub Actions and add permissions check [TMZ-1071] - #685
Merged
Ntnelbaba merged 1 commit intoAug 20, 2026
Merged
Conversation
…MZ-1071] - Remove legacy publish-*.yml workflows (superseded by deploy.yml) - Remove 7 unused composite actions under .github/actions/ - Remove 11 scripts under .github/scripts/ that were only referenced by the above (or already had zero references) - Add .github/workflows/permissions/action.yml mirroring elementor/elementor's permissions composite action, with a substring-safe token match (comma-wrapped grep -F) - Wire permissions action into deploy.yml's validate job and drop the inline hardcoded actor allow-list on the build job Ref: TMZ-1071 Co-authored-by: Cursor <cursoragent@cursor.com>
Ntnelbaba
enabled auto-merge (squash)
August 19, 2026 12:56
Hello Elementor BuildLast updated at: 20260819.1255 ✅ Hello Elementor build is ready for download. You can download the latest build from the link below: The build is available for 7 days. |
ManorHazaz
approved these changes
Aug 20, 2026
Ntnelbaba
deleted the
internal/TMZ-1071-cleanup-workflows-add-permissions
branch
August 20, 2026 06:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-beta.yml,publish-patch.yml,publish-release.yml) that were superseded bydeploy.ymland no longer wired to anything..github/actions/and 11 scripts under.github/scripts/that were only referenced by the deleted workflows (or already had zero references anywhere in the repo)..github/workflows/permissions/action.yml, mirroring the composite action used inelementor/elementor. Includes a fix for a substring-match bug in the upstream logic — the actor and permitted list are now wrapped in comma delimiters beforegrep -F, so a short handle can't match a longer permitted username.deploy.yml'svalidatejob (inputs:ENVIRONMENT: prod,DEPLOYMENT_PERMITTED: vars.DEPLOYMENT_PERMITTED_USERS,DEPLOYMENT_REPOSITORY_OWNER: elementor) and drop the inline hardcoded actor allow-list that was previously on thebuildjob.Jira
TMZ-1071
Test plan
Deployworkflow_dispatch as a user invars.DEPLOYMENT_PERMITTED_USERS— permissions step passes.Deployworkflow_dispatch as a user not in the list — permissions step fails with a clear::error::message andbuild/deployjobs are skipped.Made with Cursor
✨ PR Description
1. Problem & Context
Centralizes deployment authorization logic into a reusable action and removes hardcoded actor checks, improving maintainability and consistency across workflows (TMZ-1071).
2. What Changed (Where)
.github/workflows/deploy.yml: Added permissions validation step; removed inline actor allowlist from build job condition.github/workflows/permissions/action.yml: New composite action checking user/repo eligibility for deployments3. How It Works
Permissions action checks: (1) repo owner matches restriction, (2) environment is dev (auto-pass), (3) actor in comma-separated DEPLOYMENT_PERMITTED list. Validation runs before build job, blocking non-permitted actors from proceeding.
4. Risks
Permissions action only blocks build; deploy still has separate
ifcondition. If both aren't kept in sync, unauthorized actors could theoretically reach deploy. Mitigation: consolidate all auth logic into single validation step.Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how