Skip to content

Fix Join.escape/3 and quoted_type specs #4804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Oct 19, 2026
+6 −2
Merged

Fix Join.escape/3 and quoted_type specs #4804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/ecto/query/builder.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ defmodule Ecto.Query.Builder do
which include all primitive types and custom user types. Also
note custom user types do not show up during compilation time.
"""
@type quoted_type :: Ecto.Type.primitive() | {non_neg_integer, atom | Macro.t()}
@type quoted_type ::
Ecto.Type.primitive()
| :atom
| {:tuple, [quoted_type]}
| {non_neg_integer, atom | Macro.t()}

@typedoc """
The accumulator during escape.
Expand Down
2 changes: 1 addition & 1 deletion lib/ecto/query/builder/join.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ defmodule Ecto.Query.Builder.Join do

"""
@spec escape(Macro.t(), Keyword.t(), Macro.Env.t()) ::
{atom, Macro.t() | nil, Macro.t() | nil, list}
{atom, Macro.t() | nil, Macro.t() | nil, Macro.t() | nil, list}
def escape({:in, _, [{var, _, context}, expr]}, vars, env)
when is_atom(var) and is_atom(context) do
{_, expr, assoc, prelude, params} = escape(expr, vars, env)
Expand Down
Loading