Skip to content

Fix invalid postgres SQL related to collation - #756

Merged
josevalim merged 5 commits into
elixir-ecto:masterfrom
lukaszsamson:ls-fix-collation
Sep 25, 2026
Merged

josevalim merged 5 commits into
elixir-ecto:masterfrom
lukaszsamson:ls-fix-collation

Conversation

@lukaszsamson

Copy link
Copy Markdown
Contributor

This PR fixes 2 issues related to COLLATE expressions.

  1. ecto_sql generated invalid SQL in ADD/ALTER COLUMN statements. The collation should stick to data type
  2. ecto would not quote collation names correctly

See https://www.postgresql.org/docs/current/sql-altertable.html https://www.postgresql.org/docs/current/collation.html

Fixes #755

@josevalim
josevalim merged commit 44f561b into elixir-ecto:master Sep 25, 2026
9 of 10 checks passed
@josevalim

Copy link
Copy Markdown
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid postgres SQL with collate

2 participants