Skip to content

Optimize Plug.MethodOverride.override_method/2 with direct map pattern match #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Oct 21, 2026
+6 −10
Merged

Optimize Plug.MethodOverride.override_method/2 with direct map pattern match #1332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions lib/plug/method_override.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,19 +51,15 @@ defmodule Plug.MethodOverride do

def call(%Plug.Conn{} = conn, []), do: conn

defp override_method(conn, %Plug.Conn.Unfetched{}) do
# Just skip it because maybe it is a content-type that
# we could not parse as parameters (for example, text/gps)
conn
end
defp override_method(conn, %{"_method" => method}) when is_binary(method) do
method = String.upcase(method, :ascii)

defp override_method(%Plug.Conn{} = conn, body_params) do
with method when is_binary(method) <- body_params["_method"],
method = String.upcase(method, :ascii),
true <- method in @allowed_methods do
if method in @allowed_methods do
%{conn | method: method}
else
_ -> conn
conn
end
end

defp override_method(conn, _body_params), do: conn
end