Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plug.Staticreturns304only when anIf-None-Matchheader value is exactly its ETag. RFC 9110 section 13.1.2 defines the field as*or a comma-separated list of entity tags, compared with the weak comparison function, which ignores theW/prefix. So these requests all get a full200today even though the file is unchanged:If-None-Match: W/"<etag>"If-None-Match: "other", "<etag>"If-None-Match: *The
W/case is the one in #1133. Cloudflare weakens the ETag when it compresses a response, so browsers behind it sendW/"<etag>"back and never get a304. That issue was about whether Plug's ETag itself should be weak. This change leaves the ETag as it is and only fixes the comparison, which the RFC requires to be weak forIf-None-Match.put_cache_header/6now splits eachIf-None-Matchvalue withPlug.Conn.Utils.list/1. It treats the request as fresh when an element is*, or when it equals the ETag once aW/prefix is removed from both. A value that is exactly the ETag still matches without splitting, so a custom:etag_generationvalue that contains a comma behaves as before.The new test "performs etag negotiation with weak etags, lists and *" checks:
W/), and*get304.200.Without the change, the test fails on the weak form. With it,
mix testpasses (616 tests) andmix format --check-formattedis clean.The two
Plug.Staticchanges are independent and merge cleanly together.