chore(deps-dev): update pytest requirement from >=8.0.0 to >=9.1.1 - #75
chore(deps-dev): update pytest requirement from >=8.0.0 to >=9.1.1#75dependabot[bot] wants to merge 1 commit into
Conversation
Updates the requirements on [pytest](https://github.com/pytest-dev/pytest) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@8.0.0...9.1.1) --- updated-dependencies: - dependency-name: pytest dependency-version: 9.1.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
srpatcha
left a comment
There was a problem hiding this comment.
Review — eDB#75 "chore(deps-dev): update pytest requirement from >=8.0.0 to >=9.1.1"
head: 6e9c5ea author: app/dependabot ci: green but hollow — the test matrix never ran on this PR (finding #1)
Verdict: Clean. pytest 9.1.1 runs this repo's suite — 23 unit and 1 functional test pass, verified below — and a dev-tool floor carries no consumer-facing compatibility cost. The one finding is that this PR's green checks prove none of that, because the job that would have is not triggered on this branch. Ironically, raising a pytest floor is the change most obviously in need of a test run.
Findings
| # | Severity | File:line | Finding | Recommended fix |
|---|---|---|---|---|
| 1 | Medium | .github/workflows/ci.yml:3-8 at this head |
The Test (Python …) matrix and Build Python Package never ran on this PR. This branch forks from 5e436bd (2026-08-25), where ci.yml triggers on pull_request: branches: [main], and this PR targets master. master was added to the trigger later in f3b1ab0, which is not in this branch. checks.txt shows only Analyze (Python), CodeQL and assign — workflows with their own triggers, none of which executes pytest. A test-runner bump merged without running the tests is the gap worth closing here. |
Rebase onto current master so the trigger applies. Sequence after eDB#82, or the matrix dies at pip install -r requirements.txt (a file that does not exist in this repo) and still tells you nothing about pytest 9. |
Not a finding, but worth stating: a [project.optional-dependencies].dev floor is invisible to anything installing edb as a library, so unlike eDB#74 this narrows nothing for consumers. And pytest 9 is a major bump — the removal of deprecated hooks and nose-style setup/teardown is the usual breakage — which is exactly why the evidence below matters more than the version number.
Dependabot's own comment about missing labels does not apply to this PR and is not repeated here.
Architecture conformance
Conforms. Dev-dependency metadata only, confined to Tier 3 eDB (master design §21). No source, import, link or manifest-entry change, so §5.1 dependency direction is untouched. No effect on the §23.2 package-format contract, since [project.optional-dependencies].dev is not part of the installed distribution's runtime requirements.
Proposed changes
None to the diff. Sequence: eDB#82 → rebase this branch → let the matrix run → merge.
Verification I ran
In a clean venv on Python 3.12.14, Linux, from pyproject.toml's dev extra (uv pip install -e ".[dev]", rc 0), the resolver selected pytest 9.1.1 — the exact floor this PR proposes — with pytest-asyncio 1.4.0, pytest-cov 7.1.0 and pytest-benchmark 5.3.0:
python -m pytest tests/unit/ -q --tb=short→ 23 passed in 0.41spython -m pytest tests/functional/ -q --tb=short→ 1 passed in 0.02s
No collection errors, no deprecation failures, and asyncio_mode = "auto" (pyproject.toml:65) still works under pytest 9 with pytest-asyncio 1.4.0 — the combination most likely to break on a pytest major bump. That is the substantive check this PR needed.
(The unit command exits 1 under the workflow's --cov=. because of the unrelated fail_under = 100 in .coveragerc:14. The tests themselves pass. See eDB#82.)
Not checked
- This PR's head was never built or tested. The runs above are against eDB#82's head, which shares
master's source tree and test suite. That is evidence about pytest 9.1.1 and this codebase, not about this branch as it stands. tests/performance/was not run — it is the suite most exposed to a pytest major bump viapytest-benchmark, andci.yml:53-55marks itcontinue-on-error: true, so CI would not tell you either.- Only Python 3.12 on Linux. The 3.10 leg cannot install at all (
requires-python = ">=3.11",pyproject.toml:11), 3.11 and the macOS/Windows legs were not exercised. - I did not read the pytest 8→9 changelog against this suite; the passing run is the only evidence offered.
Automated architecture review of 6e9c5eaf3d82 — scheduled, model claude-opus-5, checked against the EmbeddedOS Master Design v2.0. Advisory only: this reviewer never approves, requests changes, or merges. Reply here to discuss or push back — a wrong finding is a bug worth reporting.
Updates the requirements on pytest to permit the latest version.
Release notes
Sourced from pytest's releases.
Commits
cf470ecPrepare release version 9.1.1e0c8ce6Merge pull request #14625 from pytest-dev/patchback/backports/9.1.x/a07c31a97...1b82d16Merge pull request #14624 from pytest-dev/patchback/backports/9.1.x/b375b79ec...501c4bcMerge pull request #14596 from bluetech/doc-classmethodb61f588Merge pull request #14622 from chrisburr/fix-14608-initial-conftest-test-subdir9a567e0[automated] Update plugin list (#14617) (#14618)ef8b299Merge pull request #14620 from pytest-dev/patchback/backports/9.1.x/680f9f3ed...66abd07Merge pull request #14220 from bysiber/fix-stale-iexp-raisesgroup79fbf93Merge pull request #14612 from pytest-dev/patchback/backports/9.1.x/974ed48b6...0d312ebMerge pull request #14611 from bluetech/parametrize-argvalues-typingDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)