Skip to content

Move template-no-class-bindings to RFC Appendix B #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NullVoxPopuli wants to merge 1 commit into from
Closed

Move template-no-class-bindings to RFC Appendix B #2843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ To disable a rule for an entire `.gjs`/`.gts` file, use a regular ESLint file-le
| [template-no-builtin-form-components](docs/rules/template-no-builtin-form-components.md) | disallow usage of built-in form components | ✅ ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) 📋 | | |
| [template-no-capital-arguments](docs/rules/template-no-capital-arguments.md) | disallow capital arguments (use lowercase @arg instead of @Arg) | ✅ ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) 📋 | | |
| [template-no-chained-this](docs/rules/template-no-chained-this.md) | disallow redundant `this.this` in templates | | 🔧 | |
| [template-no-class-bindings](docs/rules/template-no-class-bindings.md) | disallow passing classBinding or classNameBindings as arguments in templates | ✅ ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) 📋 | | |
| [template-no-class-bindings](docs/rules/template-no-class-bindings.md) | disallow passing classBinding or classNameBindings as arguments in templates | 📋 | | |
| [template-no-curly-component-invocation](docs/rules/template-no-curly-component-invocation.md) | disallow curly component invocation, use angle bracket syntax instead | 📋 | 🔧 | |
| [template-no-debugger](docs/rules/template-no-debugger.md) | disallow {{debugger}} in templates | ✅ ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) 📋 | | |
| [template-no-duplicate-attributes](docs/rules/template-no-duplicate-attributes.md) | disallow duplicate attribute names in templates | ✅ ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) 📋 | 🔧 | |
Expand Down
2 changes: 1 addition & 1 deletion docs/rules/template-no-class-bindings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ember/template-no-class-bindings

💼 This rule is enabled in the following [configs](https://github.com/ember-cli/eslint-plugin-ember#-configurations): ✅ `recommended`, ![gjs logo](/docs/svgs/gjs.svg) `recommended-gjs`, ![gts logo](/docs/svgs/gts.svg) `recommended-gts`, 📋 `template-lint-migration`.
💼 This rule is enabled in the 📋 `template-lint-migration` [config](https://github.com/ember-cli/eslint-plugin-ember#-configurations).

> **HBS Only**: This rule applies to classic `.hbs` template files only (loose mode). It is not relevant for `gjs`/`gts` files (strict mode), where these patterns cannot occur.

Expand Down
1 change: 0 additions & 1 deletion lib/recommended-rules-gjs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ module.exports = {
'ember/template-no-block-params-for-html-elements': 'error',
'ember/template-no-builtin-form-components': 'error',
'ember/template-no-capital-arguments': 'error',
'ember/template-no-class-bindings': 'error',
'ember/template-no-debugger': 'error',
'ember/template-no-duplicate-attributes': 'error',
'ember/template-no-duplicate-id': 'error',
Expand Down
1 change: 0 additions & 1 deletion lib/recommended-rules-gts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ module.exports = {
'ember/template-no-block-params-for-html-elements': 'error',
'ember/template-no-builtin-form-components': 'error',
'ember/template-no-capital-arguments': 'error',
'ember/template-no-class-bindings': 'error',
'ember/template-no-debugger': 'error',
'ember/template-no-duplicate-attributes': 'error',
'ember/template-no-duplicate-id': 'error',
Expand Down
2 changes: 0 additions & 2 deletions lib/rules/template-no-class-bindings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ module.exports = {
docs: {
description: 'disallow passing classBinding or classNameBindings as arguments in templates',
category: 'Best Practices',
recommendedGjs: true,
recommendedGts: true,
url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-class-bindings.md',
templateMode: 'loose',
},
Expand Down
2 changes: 0 additions & 2 deletions tests/__snapshots__/recommended.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ exports[`recommended rules > gjs config has the right list 1`] = `
"template-no-block-params-for-html-elements",
"template-no-builtin-form-components",
"template-no-capital-arguments",
"template-no-class-bindings",
"template-no-debugger",
"template-no-duplicate-attributes",
"template-no-duplicate-id",
Expand Down Expand Up @@ -112,7 +111,6 @@ exports[`recommended rules > gts config has the right list 1`] = `
"template-no-block-params-for-html-elements",
"template-no-builtin-form-components",
"template-no-capital-arguments",
"template-no-class-bindings",
"template-no-debugger",
"template-no-duplicate-attributes",
"template-no-duplicate-id",
Expand Down
Loading