Repository navigation
Conversation
- Find snippets in gjs/gts files by default - Highlight gjs/gts (`<template>` as Handlebars) in snippets and Markdown - Derive DocsDemo labels/language for ts, gjs and gts snippets - Infer DocsSnippet language from the snippet file extension - Index gjs/gts pages for search and include them in edit links - Add dummy app gts/gjs examples, docs and tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The release, beta and canary channels now resolve to ember-source 7.x, which is a v2 addon without the `paths` the classic ember-cli build needs, so `new EmberAddon` crashes before any test runs. Test the latest 6.x LTS instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for TypeScript and
.gjs/.gtsfiles in demos and snippets.gtsandgjsare added to the defaultsnippetExtensions(tswas already there).<template>blocks as Handlebars. Registered for Markdown code fences /highlightCodeand forDocsCodeHighlight.DocsDemo: default label/language for.ts,.gjsand.gtssnippets.DocsSnippet: infers its language from the snippet file extension when@languageisn't given (js,ts,gjs,gts,hbs,css,json)..gjs/.gtspages are indexed for search (template contents extracted withcontent-tag, now a direct dependency) and are matched by the "edit this page" link..gts/.gjsdemo components and a docs section, thesnippetExtensionsdefault in the build-options docs is corrected, plus integration (gjs), unit and node tests.Notes
ember-cli-addon-docs-yuidoc; no change needed here.compile-markdown.jsanddocs-code-highlightbecause the Node build can't share a relative import with the browser bundle.CI fix (ember-release / ember-beta / ember-canary)
The
ember-release,ember-betaandember-canarycompatibility jobs were already failing onmain(and on other PRs), independent of this change. Those channels now resolve to ember-source 7.x, which is a v2 addon without thepathsthat the classic ember-cli build (6.2) needs, sonew EmberAddoncrashes before any test runs (Cannot read properties of undefined (reading 'debug')in_initVendorFiles).This PR replaces those three scenarios in
tests/dummy/config/ember-try.jsand.github/workflows/ci-cd.ymlwithember-lts-6.12, which passes all 71 tests. The release/beta/canary channels can only be tested again once the addon's build moves to Vite/Embroider.If you'd prefer to keep this separate from the gts/gjs work, the CI change is a single commit (f8bfc4d) and can be split into its own PR.
Testing
pnpm test:nodeandpnpm test:emberpass; ESLint passes. All CI checks are green, including the newember-lts-6.12scenario.