Skip to content

Deprecate this.get and this.set on test contexts#1203

Draft
Copilot wants to merge 1 commit into
mainfrom
copilot/deprecate-get-set-on-test-contexts
Draft

Deprecate this.get and this.set on test contexts#1203
Copilot wants to merge 1 commit into
mainfrom
copilot/deprecate-get-set-on-test-contexts

Conversation

Copilot AI commented Jun 22, 2026

Copy link
Copy Markdown

Propose Deprecate this.get and this.set on Test Contexts

Rendered

Summary

This pull request is proposing a new RFC.

Logical conclusion of RFC #785: formally deprecates this.get/this.set on the test context now that the modern replacements (render(component) + rerender()) have been stable since Ember 4.5.0.

The old pattern is broken in three ways: it's run-wrapped (synchronous full DOM flush on every call), inconsistent with post-Octane tracked state, and causes TypeScript friction from arbitrary this property augmentation. The modern replacement is local @tracked state passed into render(<template>…</template>), with rerender() to await DOM updates.

RFC covers: deprecation warning message, eslint-plugin-ember lint rule, blueprint updates, and a codemod for automated migration.

To succeed, it will need to pass into the Exploring Stage, followed by the Accepted Stage.

A Proposed or Exploring RFC may also move to the Closed Stage if it is withdrawn by the author or if it is rejected by the Ember team. This requires an "FCP to Close" period.

An FCP is required before merging this PR to advance to Accepted.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Ready for Released Stage.

Exploring Stage Description

This stage is entered when the Ember team believes the concept described in the RFC should be pursued, but the RFC may still need some more work, discussion, answers to open questions, and/or a champion before it can move to the next stage.

An RFC is moved into Exploring with consensus of the relevant teams. The relevant team expects to spend time helping to refine the proposal. The RFC remains a PR and will have an Exploring label applied.

An Exploring RFC that is successfully completed can move to Accepted with an FCP is required as in the existing process. It may also be moved to Closed with an FCP.

Accepted Stage Description

To move into the "accepted stage" the RFC must have complete prose and have successfully passed through an "FCP to Accept" period in which the community has weighed in and consensus has been achieved on the direction. The relevant teams believe that the proposal is well-specified and ready for implementation. The RFC has a champion within one of the relevant teams.

If there are unanswered questions, we have outlined them and expect that they will be answered before Ready for Release.

When the RFC is accepted, the PR will be merged, and automation will open a new PR to move the RFC to the Ready for Release stage. That PR should be used to track implementation progress and gain consensus to move to the next stage.

Checklist to move to Exploring

  • The team believes the concepts described in the RFC should be pursued.
  • The label S-Proposed is removed from the PR and the label S-Exploring is added.
  • The Ember team is willing to work on the proposal to get it to Accepted

Checklist to move to Accepted

  • This PR has had the Final Comment Period label has been added to start the FCP
  • The RFC is announced in #news-and-announcements in the Ember Discord.
  • The RFC has complete prose, is well-specified and ready for implementation.
    • All sections of the RFC are filled out.
    • Any unanswered questions are outlined and expected to be answered before Ready for Release.
    • "How we teach this?" is sufficiently filled out.
  • The RFC has a champion within one of the relevant teams.
  • The RFC has consensus after the FCP period.

Copilot AI requested a review from kategengler June 22, 2026 16:15
@kategengler kategengler changed the title RFC: Deprecate this.get and this.set on test contexts Deprecate this.get and this.set on test contexts Jun 22, 2026
@kategengler

Copy link
Copy Markdown
Member

Created with copilot as a placeholder 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants