Conversation
Restore the frame on the normal return path only, matching the rest of emscripten: a JS caller that catches an exception and carries on owns the stackSave/stackRestore (emscripten-core#27748). The throwing-conversion section of the test goes with it, and hello_embind shrinks by 23 bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows sbc100's review on #27610. The invoker no longer restores the stack frame on an exception path, since callers that catch an exception from the module and carry on own the stackSave/stackRestore (#27748 makes the docs say so). The frame is released on the normal return path only. The throwing-conversion section of test_embind_trivial_value_stack goes with it, and the hello_embind codesize expectation drops by 23 bytes.