Conversation
After llvm/llvm-project#222747, user code will not directly access `__was_lpad_context` but instead get its address via `_Unwind_GetWasmLPadContext` function call. This is done for WASIp3 cooperative threading + dynamic library support, but doing this unconditionally in all cases is simple and does not have any downsides. Because we update our LLVM libraries perodically, to make llvm/llvm-project#222747 pass our autorollers, this applies its library side changes here first to match its codegen changes.
aheejin
commented
Sep 20, 2026
| name = 'libunwind' | ||
| # Because calls to _Unwind_CallPersonality are generated during LTO, libunwind | ||
| # can't currently be part of LTO. | ||
| # Because calls to _Unwind_GetWasmLPadContext are generated during LTO, |
Member
Author
There was a problem hiding this comment.
Drive-by fix: _Unwind_CallPersonality was deleted from the library in #27445 but I forgot to remove this, but now we have a new function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After llvm/llvm-project#222747, user code will not directly access
__was_lpad_contextbut instead get its address via_Unwind_GetWasmLPadContextfunction call. This is done for WASIp3 cooperative threading + dynamic library support, but doing this unconditionally in all cases is simple and does not have any downsides.Because we update our LLVM libraries perodically, to make llvm/llvm-project#222747 pass our autorollers, this applies its library side changes here first to match its codegen changes.