Skip to content

[test] Fix 120 msec timeout in test_fetch_headers_received - #28356

Merged
juj merged 1 commit into
emscripten-core:mainfrom
juj:fix_test_fetch_headers_received_timeout
Nov 21, 2026
Merged

juj merged 1 commit into
emscripten-core:mainfrom
juj:fix_test_fetch_headers_received_timeout

Conversation

@juj

@juj juj commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Fix typo with msecs -> seconds in test.

@sbc100 sbc100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but bypassing auto-merge.

Can you come up with succinct commit message? This seems like just a typo that needs fixing.. I'm not sure we need all the background info in out commit log. Feel free to either update the PR description or just edit the commit message when hit commit.

@juj
juj force-pushed the fix_test_fetch_headers_received_timeout branch from 1f107af to 46d7788 Compare November 21, 2026 15:48
@juj
juj merged commit c7360e7 into emscripten-core:main Nov 21, 2026
7 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants