Repository navigation
Conversation
Fixes: emscripten-core#20173 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
sbc100
reviewed
Nov 21, 2026
sbc100
left a comment
Collaborator
There was a problem hiding this comment.
It seems like all of this but the test is pure boilderplate, is that right? Anything I should look at in particular?
lgtm, but needs a rebase since I just releases 7.0.1 (changelog entry needs moving)
| 'simple_enable': (['-DTEST_SIMPLE_ENABLE', '-sGL_SUPPORT_AUTOMATIC_ENABLE_EXTENSIONS=0'],), | ||
| 'assertions': (['-sGL_ASSERTIONS'],), | ||
| 'closure': (['-O2', '-g1', '--closure=1'],), | ||
| 'offscreenframebuffer_pthread': (['-sOFFSCREEN_FRAMEBUFFER', '-pthread', '-sPROXY_TO_PTHREAD'],), |
Collaborator
There was a problem hiding this comment.
Should all gl extension test get these 7 variants? (Doesn't have to be part of this PR but just wondering?)
Collaborator
Author
There was a problem hiding this comment.
That might be good. Each of these variants do have some unique functionalities in them. Might be able to combine a couple, but in general having more tests is better.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #20173
This extension has been a community approved extension for quite a while, I missed it from before thinking it was still in draft phase.
https://registry.khronos.org/webgl/extensions/