Skip to content

Add support for the WebGL 2 extension OVR_multiview2 - #28361

Open
juj wants to merge 2 commits into
emscripten-core:mainfrom
juj:webgl_ovr_multiview2
Open

juj wants to merge 2 commits into
emscripten-core:mainfrom
juj:webgl_ovr_multiview2

Conversation

@juj

@juj juj commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator

Fixes: #20173

This extension has been a community approved extension for quite a while, I missed it from before thinking it was still in draft phase.

https://registry.khronos.org/webgl/extensions/

Fixes: emscripten-core#20173

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@juj juj added the GL label Nov 21, 2026

@sbc100 sbc100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like all of this but the test is pure boilderplate, is that right? Anything I should look at in particular?

lgtm, but needs a rebase since I just releases 7.0.1 (changelog entry needs moving)

Comment thread test/test_browser.py Resolved
Comment thread test/test_browser.py
'simple_enable': (['-DTEST_SIMPLE_ENABLE', '-sGL_SUPPORT_AUTOMATIC_ENABLE_EXTENSIONS=0'],),
'assertions': (['-sGL_ASSERTIONS'],),
'closure': (['-O2', '-g1', '--closure=1'],),
'offscreenframebuffer_pthread': (['-sOFFSCREEN_FRAMEBUFFER', '-pthread', '-sPROXY_TO_PTHREAD'],),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all gl extension test get these 7 variants? (Doesn't have to be part of this PR but just wondering?)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be good. Each of these variants do have some unique functionalities in them. Might be able to combine a couple, but in general having more tests is better.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Support for WebGL2 OVR_multiview2 extension

2 participants