Skip to content

Fix -jsDFOO=0 - #28364

Open
juj wants to merge 1 commit into
emscripten-core:mainfrom
juj:jsD_integer_values
Open

juj wants to merge 1 commit into
emscripten-core:mainfrom
juj:jsD_integer_values

Conversation

@juj

@juj juj commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator

The value of a -jsDFOO= setting was always passed to the JS compiler as a string, so with -jsDFOO=0 the JS library directive #if FOO was true, as the string '0' is truthy. Convert integer values to numbers, like is done with -s settings.

The value of a -jsDFOO=<value> setting was always passed to the JS compiler as a string, so with -jsDFOO=0 the JS library directive `#if FOO` was true, as the string '0' is truthy. Convert integer values to numbers, like is done with -s settings.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@juj
juj force-pushed the jsD_integer_values branch from 805a07c to b28091f Compare November 21, 2026 22:23

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant