Signpost: Add non-directional variant #2933 - #2936
Open
joshuajenner wants to merge 3 commits into
Open
joshuajenner wants to merge 3 commits into
joshuajenner wants to merge 3 commits into
Conversation
manuq
requested changes
Sep 22, 2026
manuq
left a comment
manuq
left a comment
Collaborator
There was a problem hiding this comment.
This is looks really promising! It works, I'm only requesting code improvements.
|
Play this branch at https://play.threadbare.game/branches/joshuajenner/Add-non-directional-sign-variant/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Author
|
Thanks for the feedback. Undid the edit to the third party sprite, and moved the edited sprite to the non-cc0 folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the sign sprite to include a non-directional variant.
Updated the
update_appearance()function in the sign scene to use the correct frame when setting thedirectionvariable.Resolves: #2933