prep: release v2.19.0 - #809
Open
kvhnuke wants to merge 11 commits into
Open
Conversation
|
💼 Build Files |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
💤 Files with no reviewable changes (9)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughThis change normalizes Ethereum transaction addresses, removes SKALE and Kaia network support, updates dependency versions across the monorepo, and sets the extension action document width to ChangesEthereum transaction and network updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The current change has no actionable merge-blocking risk identified and is merge-ready after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/extension/src/providers/ethereum/libs/transaction/decoder.ts (1)
62-73: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueLGTM on lowercase market-data lookup, minor duplication.
Lowercasing the contract address for
getMarketInfoByContractsand the subsequentmarketInfolookups correctly addresses the casing mismatch.tx.to!.toLowerCase()is computed 4 times though; extracting it once would avoid the repeated work and improve readability.♻️ Optional refactor
+ const lowerTo = tx.to!.toLowerCase(); await marketData .getMarketInfoByContracts( - [tx.to!.toLowerCase()], + [lowerTo], network.coingeckoPlatform!, ) .then(marketInfo => { - if (marketInfo[tx.to!.toLowerCase()]) { + if (marketInfo[lowerTo]) { currentPriceUSD = - marketInfo[tx.to!.toLowerCase()]!.current_price ?? 0; - CGToken = marketInfo[tx.to!.toLowerCase()]!.id; + marketInfo[lowerTo]!.current_price ?? 0; + CGToken = marketInfo[lowerTo]!.id; } });🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/extension/src/providers/ethereum/libs/transaction/decoder.ts` around lines 62 - 73, In the transaction decoder logic, the lowercase contract address is computed repeatedly via tx.to!.toLowerCase() inside the market-data lookup and response access, which adds unnecessary duplication. Refactor the flow in the decoder.ts handler by extracting that value once into a local variable and reusing it for getMarketInfoByContracts and the marketInfo indexing, keeping the existing behavior in the decoder logic unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/extension/src/providers/ethereum/libs/transaction/decoder.ts`:
- Line 89: The DecodedTx mapping in decoder.ts is still calling toLowerCase on
tx.to via a non-null assertion, which will crash for contract-creation
transactions where tx.to is absent. Update the decoding logic around the tx.to
assignment so it safely handles undefined/null values, preserving the existing
behavior for contract creation by leaving toAddress unset or passing through the
missing value without invoking string methods.
---
Nitpick comments:
In `@packages/extension/src/providers/ethereum/libs/transaction/decoder.ts`:
- Around line 62-73: In the transaction decoder logic, the lowercase contract
address is computed repeatedly via tx.to!.toLowerCase() inside the market-data
lookup and response access, which adds unnecessary duplication. Refactor the
flow in the decoder.ts handler by extracting that value once into a local
variable and reusing it for getMarketInfoByContracts and the marketInfo
indexing, keeping the existing behavior in the decoder logic unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b55cd4ad-d20e-41c1-94a3-81e9491efee2
📒 Files selected for processing (1)
packages/extension/src/providers/ethereum/libs/transaction/decoder.ts
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/extension-bridge/package.json`:
- Around line 52-53: Align the ESLint dependency with eslint-config-airbnb-base
in packages/extension-bridge/package.json (lines 52-53),
packages/hw-wallets/package.json (lines 28-29), packages/storage/package.json
(lines 33-34), packages/types/package.json (lines 31-32),
packages/utils/package.json (lines 36-37), and packages/swap/package.json (lines
47-48) by changing eslint from the 9.x range to a compatible ESLint 8.x range,
or consistently removing/migrating eslint-config-airbnb-base if ESLint 9 is
required; update the corresponding lockfile dependencies as needed.
In `@packages/keyring/package.json`:
- Around line 41-42: Align the ESLint and Airbnb configuration versions in
packages/keyring/package.json lines 41-42, packages/name-resolution/package.json
lines 28-29, packages/request/package.json lines 37-38,
packages/signers/bitcoin/package.json lines 38-39,
packages/signers/ethereum/package.json lines 38-39,
packages/signers/kadena/package.json lines 36-37,
packages/signers/massa/package.json lines 41-42, and
packages/signers/polkadot/package.json lines 37-38 by using an ESLint 8.x
version compatible with eslint-config-airbnb-base@15.0.0, or consistently
migrating/removing that Airbnb configuration in each affected manifest.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 00de45f2-ac56-40b0-9941-be478954ecf5
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (16)
package.jsonpackages/extension-bridge/package.jsonpackages/extension/package.jsonpackages/hw-wallets/package.jsonpackages/keyring/package.jsonpackages/name-resolution/package.jsonpackages/request/package.jsonpackages/signers/bitcoin/package.jsonpackages/signers/ethereum/package.jsonpackages/signers/kadena/package.jsonpackages/signers/massa/package.jsonpackages/signers/polkadot/package.jsonpackages/storage/package.jsonpackages/swap/package.jsonpackages/types/package.jsonpackages/utils/package.json
Fix/solana atl lookup
kvhnuke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
UI Improvements
Network Updates
Chores