[pull] main from livekit:main - #469
Merged
Merged
Conversation
SDPFragment.Unmarshal indexed into a line knowing only that it was
non-empty, so a bare "m" line panicked on line[2:] and a bare "a" line
panicked on line[1]. Both are reachable from a client supplied WHIP
Trickle ICE fragment. Length check before indexing, and require an m=
line to carry a value since Marshal drops the m= line when info is
empty.
While in the file:
- GetIP dereferenced ConnectionInformation.Address, which is a
pointer and can be nil, after only checking ConnectionInformation
itself.
- PatchICECredentialAndCandidatesIntoSDP removed candidate attributes
while ranging over the same slice by index. range captured the
original length, so after the first removal every index was stale:
consecutive candidates were skipped and stale trailing elements
re-read, leaving old candidates behind on an ICE restart. Replaced
with an in-place filter.
- s.media.ice was dereferenced unguarded in ExtractICECredential and
PatchICECredentialAndCandidatesIntoSDP, where a sibling check for
it already existed.
Adds a malformed fragment table test and a fuzz target that checks
Unmarshal never panics and that a parsed fragment re-parses equal after
Marshal.
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )