fix(explorer): preserve focus when auto-opening untracked files - #566
Open
emrearmagan wants to merge 2 commits into
Open
emrearmagan wants to merge 2 commits into
emrearmagan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the Explorer focused when auto-opening an untracked file in inline layout.
Problem
With
auto_open_on_cursor = true, moving onto an untracked file withj/kopens the file but also moves focus from the Explorer to the diff pane.This happens when the file's buffer has not been loaded yet.
open_real_file()switches to the diff window to run:edit, but does not switch back afterward.Fix
Use
vim.api.nvim_win_call()to run:editin the diff window without changing the user's current window.Testing
./tests/run_tests.sh tests/integration/ui/explorer/creation_spec.lua— 18 passed, 0 failedstylua --check lua/codediff/ui/view/helpers.luagit diff --check