fix(timings): aggregate all versions in collapsed client row#441
Merged
Conversation
The collapsed row previously showed whichever single version had the most observations, which over longer ranges is the oldest commit. It now shows a weighted aggregate across all versions for the selected period, and expanding lists every version sorted newest-first by when it was last seen.
Adds an Active column to the client version breakdown showing each version's activity window as a relative range (e.g. "22h – 18h ago", "18h ago – now") with absolute local dates in the tooltip. Restores the observations column on the EL Client Duration table and makes fastest-first the default sort regardless of column visibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collapsed client row in the EL Client Duration table showed the single most-observed version, which over a 7-day range is usually the oldest commit (it has been running longest). Besu's row was headlining a stale commit's numbers (reported by @siladu / @matkt).