[fork CI only] loop-free search, tests past main's pyright error - #2
Closed
etiferrier wants to merge 2 commits into
Closed
etiferrier wants to merge 2 commits into
etiferrier wants to merge 2 commits into
Conversation
`_find_idx_with_hint` walked from the hint with two `lax.while_loop`s. It runs on every step of an adaptive solve, and on GPU each `while_loop` iteration costs a device-to-host synchronisation, so the search added a fixed cost to every step. Use an unrolled binary search (`jnp.searchsorted(..., method="scan_unrolled")`) instead: O(log len(ts)) fused comparisons, no loop. Same result, same dtype. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Fork CI only; the change is now upstream as patrick-kidger#777. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only CI run: the PR commit plus continue-on-error on pre-commit, so that the tests and docs build run despite pyright's _misc.py:175 error (also on main). Not for upstream.
🤖 Generated with Claude Code