Tool Call Reasoning Example#19232
Conversation
|
I see build suddenly failed now, however, not able to see details, please advise, thanks |
theangrydev
left a comment
theangrydev
left a comment
There was a problem hiding this comment.
Can you please apply the Baeldung formatting code style:
https://github.com/Baeldung/dev-settings/tree/main/javaCodeStyle
| * - Whether thinking blocks accumulate correctly in both scenarios | ||
| */ | ||
| @Test | ||
| void parkingDecisionMakerWithMultiProbes() { |
There was a problem hiding this comment.
Please follow the guidelines regarding BDD test names, the format should be either
givenXxxYyy_whenXxxYyy_thenXxxYyy
whenXxxYyy_thenXxxYyy
| * - Whether thinking blocks accumulate correctly in both scenarios | ||
| */ | ||
| @Test | ||
| void parkingDecisionMakerWithMultiProbes() { |
There was a problem hiding this comment.
This test is very verbose and reads more like a demo script than a real test, relying mostly on logging and conditional sections that I wouldn't usually expect to see in a test - was this intentional?
There is also no separation between test code and production code - I can't easily tell which parts are the "system under test" vs which parts are only the test harness
| <configuration> | ||
| <source>21</source> | ||
| <target>21</target> | ||
| <release>21</release> | ||
| </configuration> |
There was a problem hiding this comment.
Why are these being set both here and in the properties section?
| * | ||
| * |
There was a problem hiding this comment.
Remove blank lines (same elsewhere)
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Remove blank lines (same elsewhere)
| * | ||
| * <link>https://github.com/embabel/embabel-agent-experimental/blob/main/embabel-experimental-integration-tests/src/test/java/com/embabel/agent/api/tool/loop/thinking/ToolCallReasoningIT.java</link> | ||
| * | ||
| * Original code (see link above)) was developed by Embabel Pty Ltd, 2026 |
There was a problem hiding this comment.
Do you have permission to reuse this without a license? The original license in the linked file is Apache, so I would expect to see the license header and reproduced, and a copy of the Apache license included
More typically, the IP used in Baeldung is usually original work - is there any reason you did not write an original example for Baeldung and chose to adapt existing work?
|
|
||
| @LlmTool(description = "Reserve guaranteed garage parking near destination.") | ||
| public String reserveGarage(String location) { | ||
|
|
There was a problem hiding this comment.
Remove blank lines at the start of methods (same elsewhere)
2 participants
OVERVIEW