Repository navigation
Conversation
preact-cli uses the abandoned esm package to load preact.config.js, which crashes under Node 24. Switch configs to CommonJS and patch preact-cli to require() them directly instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
tried testing on staging, and I can't simulate a charge eventually failing, only blocked at frontend synchronous, but I don't think it's harmful to see if it works in prod |
Contributor
Author
|
Closing in favor of #462 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preact-cliloadspreact.config.jsvia the unmaintainedesmpackage, which crashes on Node 24preact.config.jsfiles to plain CommonJS exportspreact-clitorequire()the config directly, falling back toesmonly if that failsTest plan
donate-button-v4: dev build and widget render verified on Node 24donate-button/donate-button-next: patch applies cleanly (a separate, pre-existing dependency issue keeps these two non-functional regardless of Node version)