Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
johnemau
changed the title
johnemau
changed the title
johnemau
changed the title
johnemau
changed the title
johnemau
marked this pull request as ready for review
September 30, 2026 15:03
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The worker README still incorrectly states that tests use service-worker-mock.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates Cloudflare Worker tests to run on Node.js 22 using native web APIs.
Changes:
- Removes
service-worker-mockand its setup. - Uses native
Request/Response, with fakes for unsupported methods. - Cleans related dependencies from package metadata.
| File | Description |
|---|---|
packages/cloudflare-worker/test/handler.ts |
Migrates tests to native web APIs. |
packages/cloudflare-worker/test/_setup.ts |
Removes service-worker environment setup. |
packages/cloudflare-worker/ava.config.js |
Stops loading the removed setup. |
packages/cloudflare-worker/package.json |
Removes mock dependencies. |
yarn.lock |
Removes resolved mock packages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
johnemau
enabled auto-merge (squash)
September 30, 2026 23:50
johnemau
added a commit
that referenced
this pull request
Oct 5, 2026
Problem: PR #462 and PR #464 both target main, so the Vite migration can be reviewed or merged before its worker test prerequisite. Root cause: Their branches diverged from the same main commit. Solution: Merge the worker test branch into PR #462 and reconcile yarn.lock so the Vite branch contains the worker fix. Manual test: Expected: The combined branch installs with an immutable lockfile, passes all package tests, builds Vite, and passes root lint on Node 24. Actual: yarn install --immutable, yarn test, yarn build, and yarn lint passed on Node 24.16.0. PRs: #464 and #462
johnemau
disabled the stack merge
October 6, 2026 15:37
johnemau
added this pull request to stack #466
October 6, 2026 15:38
johnemau
force-pushed
the
john-with-claude/miniflare-node24-tests
branch
from
October 8, 2026 12:09
41dfbc0 to
c1d037c
Compare
johnemau
removed this pull request from stack #466
October 8, 2026 14:19
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Remove the service-worker-mock test setup, which replaced Node globals and depends on an unmaintained package. The handler tests build requests with Node's native Request and Response against an assets.every.org.test URL; CONNECT and TRACE, which Request rejects, use request-shaped objects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
johnemau
force-pushed
the
john-with-claude/miniflare-node24-tests
branch
from
October 8, 2026 14:27
1d7ec89 to
e1a32df
Compare
johnemau
changed the base branch from
main
to
john-with-claude/node-24-donate-testing-80be4e
October 8, 2026 14:28
johnemau
added this pull request to stack #469
October 8, 2026 14:28
johnemau
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
Problem
service-worker-mock.Root cause
Solution
RequestandResponse.CONNECTandTRACE, which nativeRequestrejects.