Repository navigation
Collect DAF details in the modal and hand off to every.org's DAF flows - #475
Merged
Merged
Conversation
Problem: The widget's DAF screen skips every.org's contact info step. "Get instructions for a manual DAF donation" shows hardcoded instructions in the widget, and "Donate with DAFpay" redirects to the generic donate page. Root Cause: The widget's manual DAF view is static text from 2023. every.org's manual flow now asks for donation details and the donor's name and email before showing instructions, and the widget never linked to it. Solution: Link the manual button to every.org's #/donate/daf/manual flow and send the Chariot submit to #/donate/daf/chariot/confirm. Add an optional `route` to the donate URL builders for these deep links, and remove the unused static manual view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem: "Get instructions for a manual DAF donation" sends donors to every.org's manual flow before they enter an amount, and skips the nonprofit's required custom fields. Solution: Add a manual step to the DAF flow that reuses the Chariot amount view with yearly, monthly and one-time frequencies, then submits to every.org's #/donate/daf/manual/confirm. useSubmitDonation now takes the route and whether to allow recurring from its caller instead of hardcoding DAF. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DAF is in OneTimeFrequencyMethods, so the manual step should not offer recurring frequencies. Drop the allowRecurring option and say "DAF only supports one-time donations", since the message now shows on both the Chariot and manual steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DAF grants have a $50 minimum, but the widget validated DAF amounts against the general $10 default. Add useMinDonationAmount, which raises the minimum to $50 when DAF is selected (a higher nonprofit minimum still wins), and use it for both the amount field and the submit check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jiwon85
marked this pull request as ready for review
October 9, 2026 17:29
Exploding
approved these changes
Oct 9, 2026
johnemau
approved these changes
Oct 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The donate button's DAF screen skipped every.org's contact info step. Donors went straight to instructions without giving their name and email.
Not caused by #471. The widget's manual DAF screen was static instructions from 2023. every.org's manual flow later added donation details and contact info steps, and the widget never linked to them. The Chariot submit also went to the generic
#/donatepage instead of the Chariot confirm page.Changes
#/donate/daf/chariot/confirm, which asks for name and email.#/donate/daf/manual/confirm. This replaces the hardcoded instructions screen. Required custom fields now apply to manual DAF too.For reviewers
useSubmitDonationnow takes an optional every.orgroutefrom the caller instead of hardcoding DAF.constructDonateUrlappends it after#/donate, and other payment methods still use#/donate.yarn workspace @everydotorg/donate-button-v4 devfails withCan't resolve 'src/autoPlayMode', runyarn installto apply the preact-cli patch from Upgrade to Node 24 (minimal) #470.🤖 Generated with Claude Code